fix #22268: allow any character in networkfirewall/ip_sets as per the… #22284
Conversation
github-actions
bot
added
needs-triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @lenios 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
…s per the api docs
anGie44
added
bug
There was a problem hiding this comment.
Hi @lenios , thank you for this fix! Overall, change looks great, just needed a run of gofmt on the code and a small update to the changelog syntax 🚀
Output of acceptance tests:
--- PASS: TestAccNetworkFirewallRuleGroup_disappears (185.18s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rules (228.95s)
--- PASS: TestAccNetworkFirewallRuleGroup_statefulRuleOptions (241.68s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statefulRule (254.63s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statelessRule (265.94s)
--- PASS: TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction (266.17s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList (1162.19s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateRules (1213.31s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatelessRule (1227.65s)
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_header (1238.38s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateRulesSourceList (1322.68s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRule (1362.58s)
--- PASS: TestAccNetworkFirewallRuleGroup_tags (1418.23s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions (1432.53s)
--- PASS: TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (1509.97s)
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_action (1578.78s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules (1581.41s)
|
This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
… api docs
Community Note
- Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
- Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
Closes #22268